[Updated] D9316: log: add argument -B/--bookmark for bookmarks
sebhtml (Sébastien Boisvert)
phabricator at mercurial-scm.org
Wed Nov 18 23:10:23 UTC 2020
sebhtml added a comment.
In D9316#140172 <https://phab.mercurial-scm.org/D9316#140172>, @martinvonz wrote:
> IMO, these three commits should be folded/squashed into a single commit. One way to think of it is this: if we decide to roll it back, would it be okay to roll back only one of them?
> Also, most of the commit message is noise to me. You can safely remove all of it, IMO. I would instead like the commit message to tell me what the feature does and why it's useful. That includes explaining that it shows the commits that are reachable only by the specified bookmark. Also explain that that matches the semantics of `hg export` (and whatever other commands it was that I pointed you to last time). Thanks.
>
>> I don't know the why some of the tests are doing a time out.
>
> Some of them are just really slow. I usually pass `-t 600` to give them more time to finish.
Got it.
So... have a question, regarding the process to follow.
Since you recommend that I put my 3 patches in 1 commit, and that I rewrite the commit message as you guided, would it make sense for me to
In D9316#140172 <https://phab.mercurial-scm.org/D9316#140172>, @martinvonz wrote:
> IMO, these three commits should be folded/squashed into a single commit. One way to think of it is this: if we decide to roll it back, would it be okay to roll back only one of them?
> Also, most of the commit message is noise to me. You can safely remove all of it, IMO. I would instead like the commit message to tell me what the feature does and why it's useful. That includes explaining that it shows the commits that are reachable only by the specified bookmark. Also explain that that matches the semantics of `hg export` (and whatever other commands it was that I pointed you to last time). Thanks.
>
>> I don't know the why some of the tests are doing a time out.
>
> Some of them are just really slow. I usually pass `-t 600` to give them more time to finish.
Hello,
I addressed your comments, see my V3 here https://phab.mercurial-scm.org/D9341
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D9316/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D9316
To: sebhtml, #hg-reviewers, martinvonz, pulkit, marmoute
Cc: mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20201118/14723c24/attachment-0002.html>
More information about the Mercurial-patches
mailing list