[Updated] D9434: tests: add a comment that we're purposely testing py2 extension attributes

mharbison72 (Matt Harbison) phabricator at mercurial-scm.org
Sat Nov 28 12:06:10 UTC 2020


Closed by commit rHG250e18437e30: tests: add a comment that we're purposely testing py2 extension attributes (authored by mharbison72).
This revision was automatically updated to reflect the committed changes.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D9434?vs=23754&id=23771

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D9434/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D9434

AFFECTED FILES
  tests/test-extension.t

CHANGE DETAILS

diff --git a/tests/test-extension.t b/tests/test-extension.t
--- a/tests/test-extension.t
+++ b/tests/test-extension.t
@@ -1423,7 +1423,8 @@
   ** Mercurial Distributed SCM * (glob)
   ** Extensions loaded: throw
 
-empty declaration of supported version, extension complains:
+empty declaration of supported version, extension complains (but doesn't choke if
+the value is improperly a str instead of bytes):
   $ echo "testedwith = ''" >> throw.py
   $ hg --config extensions.throw=throw.py throw 2>&1 | egrep '^\*\*'
   ** Unknown exception encountered with possibly-broken third-party extension throw
@@ -1434,7 +1435,8 @@
   ** Mercurial Distributed SCM (*) (glob)
   ** Extensions loaded: throw
 
-If the extension specifies a buglink, show that:
+If the extension specifies a buglink, show that (but don't choke if the value is
+improperly a str instead of bytes):
   $ echo 'buglink = "http://example.com/bts"' >> throw.py
   $ rm -f throw.pyc throw.pyo
   $ rm -Rf __pycache__



To: mharbison72, #hg-reviewers, pulkit
Cc: mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20201128/688a6a15/attachment-0002.html>


More information about the Mercurial-patches mailing list