[Changed Subscribers] D9418: copies: clarify the return of _merge_copies_dict

marmoute (Pierre-Yves David) phabricator at mercurial-scm.org
Mon Nov 30 09:27:05 UTC 2020


marmoute added inline comments.

INLINE COMMENTS

> pulkit wrote in copies.py:466
> Is there any reason we will like to return this?

Absolutely. It allow us to (update and) return whichever of the two dicts we prefer depending on the situation.

(it also make the code a bit clearer, since we don't have to remember which of the two dict argument get updated)

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D9418/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D9418

To: Alphare, #hg-reviewers
Cc: marmoute, pulkit, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20201130/07abccaa/attachment-0002.html>


More information about the Mercurial-patches mailing list