[Updated] D9120: salvaged: record salvaged in ChangingFiles at commit time

[marmoute (Pierre-Yves David)]

marmoute added inline comments.

INLINE COMMENTS

> Alphare wrote in commit.py:150
> Coming from a Rust development perspective, `_stateextras` would be a private method and you wouldn't be able to access it here.
> I've seen a lot of "abstraction leakage" in the Python codebase, so I'm wondering if this is justified, as in "this is a temporary solution and will disappear in a few patches or "this would require a huge refactor otherwise", or even "this should be a public attribute".

This is the junction of my work and Pulkit work. My plan here is to first make it work so that we can see what data we need when. From there, we can cleanup the code and add the necessary API.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D9120/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D9120

To: marmoute, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mercurial-scm.org/pipermail/mercurial-patches/attachments/20201002/7b143739/attachment.html>