[Updated] D9137: rust: leverage improved match ergonomics

Alphare (Raphaël Gomès) phabricator at mercurial-scm.org
Thu Oct 1 15:33:02 UTC 2020


Closed by commit rHGd5407b2e7689: rust: leverage improved match ergonomics (authored by Alphare).
This revision was automatically updated to reflect the committed changes.
This revision was not accepted when it landed; it landed in state "Needs Review".

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D9137?vs=22965&id=22974

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D9137/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D9137

AFFECTED FILES
  rust/hg-core/src/dirstate/status.rs

CHANGE DETAILS

diff --git a/rust/hg-core/src/dirstate/status.rs b/rust/hg-core/src/dirstate/status.rs
--- a/rust/hg-core/src/dirstate/status.rs
+++ b/rust/hg-core/src/dirstate/status.rs
@@ -730,7 +730,7 @@
                         .symlink_metadata();
 
                     match meta {
-                        Ok(ref m)
+                        Ok(m)
                             if !(m.file_type().is_file()
                                 || m.file_type().is_symlink()) =>
                         {
@@ -749,7 +749,7 @@
                             );
                             Ok((Cow::Owned(filename), dispatch))
                         }
-                        Err(ref e)
+                        Err(e)
                             if e.kind() == ErrorKind::NotFound
                                 || e.raw_os_error() == Some(20) =>
                         {
@@ -783,7 +783,7 @@
                 let meta =
                     self.root_dir.join(filename_as_path).symlink_metadata();
                 match meta {
-                    Ok(ref m)
+                    Ok(m)
                         if !(m.file_type().is_file()
                             || m.file_type().is_symlink()) =>
                     {
@@ -802,7 +802,7 @@
                             self.options,
                         ),
                     )),
-                    Err(ref e)
+                    Err(e)
                         if e.kind() == ErrorKind::NotFound
                             || e.raw_os_error() == Some(20) =>
                     {



To: Alphare, #hg-reviewers
Cc: martinvonz, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20201001/0ad44027/attachment-0002.html>


More information about the Mercurial-patches mailing list