[Updated] D9179: errors: name arguments to Abort constructor

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Fri Oct 9 15:06:12 UTC 2020


martinvonz added inline comments.

INLINE COMMENTS

> test-url.py:395
>      ... except error.Abort as e:
> -    ...   forcebytestr(e)
> +    ...   e.message
>      'file:// URLs can only refer to localhost'

This needs to be wrapped in `pycompat.bytestr()` to work on py3. Sorry I didn't notice before. Want me to fold that in in flight or send a follow-up?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D9179/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D9179

To: martinvonz, durin42, #hg-reviewers, pulkit
Cc: mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20201009/efc6167a/attachment-0002.html>


More information about the Mercurial-patches mailing list