[Commented On] D9171: tests: add test of copies suggested by Pierre-Yves on D9159

[martinvonz (Martin von Zweigbergk)]

martinvonz added a comment.


  In D9171#138205 <https://phab.mercurial-scm.org/D9171#138205>, @marmoute wrote:
  
  > This test case should go in `tests/test-copies-chain-merge.t` since this is where the combination of merging and copies information is tested.
  
  That is *one* place where copies and merges are tested, but not the only place. Just search for "merge" in this file if you're curious. There was a very similar case just above the one I added.
  
  > It would also ensure that it is properly tested on all the relevant cases.
  
  OTOH, until my next patch in this series, that would mean that it would *not* be tested with copy information in extras.
  
  > Can we drop it in its current form, and restart review based on a diff on `tests/test-copies-chain-merge.t` ?
  
  I don't see any reason to.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D9171/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D9171

To: martinvonz, #hg-reviewers, pulkit
Cc: marmoute, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20201013/3ec44f1c/attachment-0002.html>