[Updated] D9056: fix: include adjacent blank lines in ranges to be fixed

[msuozzo (Matthew Suozzo)]

msuozzo added a comment.


  I'm definitely sympathetic to your position.
  
  As discussed offline, I think an improvement to generality would be to change this config option to relate to deletion diff policies instead and have adjacent blanks be a policy therein.
  
  I'm flexible on naming here. I think "emitdeletedranges" is a bit clunky but I can't think of something that fits much better.
  
  PTAL and thanks!

INLINE COMMENTS

> hooper wrote in fix.py:49
> I would explain this more fully by framing it, roughly, as three points:
> 
> 1. There is a config that will expand *all* changed line ranges to include adjacent blank lines.
> 2. This is useful because it inhibits the previously described omission of deleted line ranges, allowing code formatters to fix whitespace surrounding deletions.
> 3. The subtleties of how we define "adjacent" and "blank line".

this is probably obsolete given the change but I did try to more rigorously define what I'm considering "whitespace" here.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D9056/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D9056

To: msuozzo, hooper, #hg-reviewers
Cc: pulkit, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20201020/c6543c3a/attachment-0002.html>