[Accepted] D8938: run-tests: refactor filtering logic for --retest flag

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Wed Sep 2 16:29:50 UTC 2020


pulkit added inline comments.
pulkit accepted this revision.

INLINE COMMENTS

> khanchi97 wrote in run-tests.py:3249
> We are not re-implementing the test build logic here. If you see next line, I think we are doing what you are suggesting i.e. filtering the existing `tests` list.

Okay, seems like I misread.

Can you follow up by adding a utility function to get errpath since we now have the same logic at couple of places (other one is ~30 lines below).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8938/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8938

To: khanchi97, #hg-reviewers, marmoute, pulkit
Cc: marmoute, pulkit, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mercurial-scm.org/pipermail/mercurial-patches/attachments/20200902/0c903359/attachment.html>


More information about the Mercurial-patches mailing list