[Commented On] D9010: hg-core: add `Changlog` a specialized `Revlog`

[Alphare (Raphaël Gomès)]

Alphare added a comment.
Alphare accepted this revision.


  Minor nits, this looks good.

INLINE COMMENTS

> changelog.rs:38
> +
> +/// `Changelog` entry which know how to interpret the `changelog` data bytes.
> +#[derive(Debug)]

/s/know/knows/

> changelog.rs:56
> +    pub fn manifest_node(&self) -> Result<&[u8], RevlogError> {
> +        self.lines().next().ok_or_else(|| RevlogError::Corrupted)
> +    }

`or_or(RevlogError::Corrupted)` is shorter and has the same behavior.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D9010/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D9010

To: acezar, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200917/e579652d/attachment-0002.html>