[Commented On] D8973: log: add support for bookmarks

[martinvonz (Martin von Zweigbergk)]

martinvonz added a comment.


  For the record, I'm -1 on this, for the following reasons:
  
  - We have revsets in order to avoid adding flags to `hg log` and other commands. However, I think it makes sense to have flags for the most common options (`-k` and `-u` are the ones I use most). I'm not sure `-B` will be common enough.
  - The semantics are unintuitive. When I first saw it, I assumed it would show just the bookmarked commit itself. When I saw some of the tests and saw that it also showed other commits, I figured it must be showing `only($bookmark)` or maybe `only($bookmark, $all_other_bookmarks)`. It instead seems to do the same as `hg log --follow $bookmark`
  - We have a `bookmark()` revset, which matches exactly the bookmarked commit, not including ancestors. It seems unfortunate for that revset and this new flag to disagree.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8973/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8973

To: sebhtml, #hg-reviewers, marmoute, pulkit
Cc: martinvonz, marmoute, pulkit, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200924/bf4327af/attachment-0002.html>