[Changed Subscribers] D9102: hg-core: use `u32` instead of `i32` in `Chunk` (D8958#inline-15001 followup)

[Alphare (Raphaël Gomès)]

Alphare added inline comments.

INLINE COMMENTS

> patch.rs:25
>      /// induced by previously applied chunks.
> -    fn start_offseted_by(&self, offset: i32) -> i32 {
> -        self.start + offset
> +    fn start_offseted_by(&self, offset: i32) -> u32 {
> +        (self.start as i32 + offset) as u32

Is the offset always positive? Same question for all affected methods.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D9102/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D9102

To: acezar, #hg-reviewers
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200928/ad44eb77/attachment-0002.html>