[Updated] D10413: lfs: use the new APIs

marmoute (Pierre-Yves David) phabricator at mercurial-scm.org
Thu Apr 15 07:28:41 UTC 2021


marmoute added inline comments.

INLINE COMMENTS

> mharbison72 wrote in storefactory.py:44
> Probably should update the comment too, now that the named function is gone.

I was a bit confused about the comment initially, but I now understand is probably about the fact `ui.expandpath(b'default')` would return `b'default'` if no default path is defined. However the comment does not match the code I replaced.

Since I already document the "issue" in `urlutil` (later in the series) I'll mostly drop this comment.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D10413/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D10413

To: marmoute, #hg-reviewers
Cc: mharbison72, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210415/b720058a/attachment-0002.html>


More information about the Mercurial-patches mailing list