[Updated] D10481: streamclone: treat volatile file as "fullfile"

[Alphare (Raphaël Gomès)]

This revision now requires changes to proceed.
Alphare added a comment.
Alphare requested changes to this revision.


  Your description is mixing "append" and "happen" again, but in the reverse order of the last patch.

INLINE COMMENTS

> store.py:392
>  REVLOG_FILES_OTHER_EXT = (b'.d', b'.n', b'.nd', b'd.tmpcensored')
> +# file that as "volatile" and might change between listing and streaming
> +#

s/as/is/

> store.py:429
>  
> +FILEFLAGS_VOLATILE = 1 << 20
> +

I think repeating a small comment here would be nice

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D10481/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D10481

To: marmoute, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210420/26583946/attachment-0002.html>