[Changed Subscribers] D10469: profiling: add --no-profile to disable profiling enabled via config

[marmoute (Pierre-Yves David)]

marmoute added inline comments.

INLINE COMMENTS

> dispatch.py:1066
>              ui_.setconfig(b'profiling', b'enabled', b'true', b'--profile')
> +    elif req.earlyoptions[b'profile'] is False:
> +        # Check for it being set already, so that we don't pollute the config

Identify testing on boolean is not recommended. This should be `elif req.earlyoptions[b'profile']`

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D10469/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D10469

To: spectral, #hg-reviewers
Cc: marmoute, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210420/68bdce78/attachment-0002.html>