[Changed Subscribers] D10437: url_util: introduce a `try_path` function

Alphare (Raphaël Gomès) phabricator at mercurial-scm.org
Tue Apr 20 14:40:01 UTC 2021


Alphare added inline comments.

INLINE COMMENTS

> urlutil.py:454
> +    try:
> +        # we pass the ui instance are warning might need to be issued
> +        return path(ui, None, rawloc=url)

s/are/as/

> urlutil.py:622
>              return None
> -
> -        try:
> +        if name in self:
>              return self[name]

This adds a lookup, why remove the initial `KeyError` handling?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D10437/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D10437

To: marmoute, #hg-reviewers
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210420/ecef4d7f/attachment-0002.html>


More information about the Mercurial-patches mailing list