[Updated] D10437: url_util: introduce a `try_path` function

marmoute (Pierre-Yves David) phabricator at mercurial-scm.org
Tue Apr 20 14:51:54 UTC 2021


marmoute added inline comments.

INLINE COMMENTS

> Alphare wrote in urlutil.py:622
> This adds a lookup, why remove the initial `KeyError` handling?

This make the flow clearer, and I don't expect it to be a performance issue. We could also use `get`, but againt, I don't expect a real difference here.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D10437/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D10437

To: marmoute, #hg-reviewers
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210420/6e94f975/attachment-0002.html>


More information about the Mercurial-patches mailing list