[Updated] D10359: sidedata: replace sidedata upgrade mechanism with the new one

[marmoute (Pierre-Yves David)]

This revision now requires changes to proceed.
marmoute added inline comments.
marmoute requested changes to this revision.

INLINE COMMENTS

> revlog.py:2129-2130
>  
> -        if sidedata is None:
> +        if not sidedata:
>              sidedata = {}
>          elif not self.hassidedata:

This is a gratuitous harmful change. If someone passed something else than the default `None` value. We should keep it.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D10359/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D10359

To: Alphare, indygreg, #hg-reviewers, marmoute
Cc: marmoute, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210428/56f16412/attachment-0002.html>