[Updated] D11211: wireprotov1peer: simplify the way batchable rpcs are defined
Alphare (Raphaël Gomès)
phabricator at mercurial-scm.org
Tue Aug 24 14:06:20 UTC 2021
This revision is now accepted and ready to land.
Alphare added inline comments.
Alphare accepted this revision.
INLINE COMMENTS
> wireprotov1peer.py:47
> encoded_args = [('one', encode(one),), ('two', encode(two),)]
> - # Create future for injection of encoded result:
> - encoded_res_future = future()
> - # Return encoded arguments and future:
> - yield encoded_args, encoded_res_future
> - # Assuming the future to be filled with the result from the batched
> - # request now. Decode it:
> - yield decode(encoded_res_future.value)
> + # Return it, along with a function that wll receive the result
> + # from the batched request.
nit: s/wll/will/
REPOSITORY
rHG Mercurial
BRANCH
default
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D11211/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D11211
To: valentin.gatienbaron, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mercurial-scm.org/pipermail/mercurial-patches/attachments/20210824/7d36f798/attachment.html>
More information about the Mercurial-patches
mailing list