[Request] [+ ] D11358: pyoxidizer: pass arch to WiXInstaller()

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Fri Aug 27 05:38:11 UTC 2021


indygreg created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  We just upgraded Windows automation to PyOxidizer 0.17.0. This
  version of PyOxidizer changed the behavior of WiX installers so
  installer architecture defaulted to "x64" (before it defaulted
  to the target of the pyoxidizer.exe binary). To allow controlling
  the architecture of the installer, the `arch` argument was added
  to `WiXInstaller`. This commit passes that argument in.

REPOSITORY
  rHG Mercurial

BRANCH
  stable

REVISION DETAIL
  https://phab.mercurial-scm.org/D11358

AFFECTED FILES
  rust/hgcli/pyoxidizer.bzl

CHANGE DETAILS

diff --git a/rust/hgcli/pyoxidizer.bzl b/rust/hgcli/pyoxidizer.bzl
--- a/rust/hgcli/pyoxidizer.bzl
+++ b/rust/hgcli/pyoxidizer.bzl
@@ -242,7 +242,7 @@
         path = "defaultrc/editor.rc",
     )
 
-    wix = WiXInstaller("hg", "%s-%s.msi" % (MSI_NAME, VERSION))
+    wix = WiXInstaller("hg", "%s-%s.msi" % (MSI_NAME, VERSION), arch = platform)
 
     # Materialize files in the manifest to the install layout.
     wix.add_install_files(manifest)



To: indygreg, #hg-reviewers
Cc: mercurial-patches, mercurial-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mercurial-scm.org/pipermail/mercurial-patches/attachments/20210827/85df0044/attachment.html>


More information about the Mercurial-patches mailing list