[Request] [+ ] D11369: dirstate-item: implement `from_p2_removed` in a simpler way
marmoute (Pierre-Yves David)
phabricator at mercurial-scm.org
Fri Aug 27 17:11:25 UTC 2021
marmoute created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.
REVISION SUMMARY
We can simply use the underlying attribute.
REPOSITORY
rHG Mercurial
BRANCH
default
REVISION DETAIL
https://phab.mercurial-scm.org/D11369
AFFECTED FILES
mercurial/pure/parsers.py
CHANGE DETAILS
diff --git a/mercurial/pure/parsers.py b/mercurial/pure/parsers.py
--- a/mercurial/pure/parsers.py
+++ b/mercurial/pure/parsers.py
@@ -295,7 +295,7 @@
This property seems like an abstraction leakage and should probably be
dealt in this class (or maybe the dirstatemap) directly.
"""
- return self.v1_state() == b'r' and self.v1_size() == FROM_P2
+ return self.removed and self._clean_p2
@property
def removed(self):
To: marmoute, #hg-reviewers
Cc: mercurial-patches, mercurial-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mercurial-scm.org/pipermail/mercurial-patches/attachments/20210827/bf845142/attachment.html>
More information about the Mercurial-patches
mailing list