[Commented On] D11238: rust-nodemap: falling back to C impl as mitigation

Alphare (Raphaël Gomès) phabricator at mercurial-scm.org
Mon Aug 2 13:49:13 UTC 2021


Alphare added a comment.
Alphare accepted this revision as: Alphare.


  I'll give other reviewers a little time to review as well, but this looks fine as a workaround. I hope we'll be able to figure out the underlying cause soon.

INLINE COMMENTS

> revlog.rs:68
> +        match nt.find_bin(idx, node.into())
> +        {
> +            Ok(None) =>

nit: I'd have added a small comment to reference issue6554 to remove the fallback once it's fixed.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11238/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11238

To: gracinet, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210802/97faf217/attachment-0002.html>


More information about the Mercurial-patches mailing list