[Commented On] D11257: pager: account for flakiness in Windows output

baymax (Baymax, Your Personal Patch-care Companion) phabricator at mercurial-scm.org
Thu Aug 5 17:32:13 UTC 2021


baymax added a comment.
baymax updated this revision to Diff 29817.


  ✅ refresh by Heptapod after a successful CI run (🐙 💚)
  ⚠ This patch is intended for stable ⚠
  <img src="https://phab.mercurial-scm.org/file/data/bth6ydklc4kd4gmh7a6h/PHID-FILE-uktushir6fpusqhvokji/source.gif" />

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D11257?vs=29810&id=29817

BRANCH
  stable

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11257/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11257

AFFECTED FILES
  tests/test-pager.t

CHANGE DETAILS

diff --git a/tests/test-pager.t b/tests/test-pager.t
--- a/tests/test-pager.t
+++ b/tests/test-pager.t
@@ -219,26 +219,26 @@
 #endif
 
 A complicated pager command gets worse behavior. Bonus points if you can
-improve this. Windows apparently does this better?
+improve this. Windows apparently does this better, but only sometimes?
 #if windows
   $ hg log --limit 3 \
   >   --config pager.pager='this-command-better-never-exist --seriously' \
   >  2>/dev/null || true
-  \x1b[0;33mchangeset:   10:46106edeeb38\x1b[0m (esc)
-  tag:         tip
-  user:        test
-  date:        Thu Jan 01 00:00:00 1970 +0000
-  summary:     modify a 10
-  
-  \x1b[0;33mchangeset:   9:6dd8ea7dd621\x1b[0m (esc)
-  user:        test
-  date:        Thu Jan 01 00:00:00 1970 +0000
-  summary:     modify a 9
-  
-  \x1b[0;33mchangeset:   8:cff05a6312fe\x1b[0m (esc)
-  user:        test
-  date:        Thu Jan 01 00:00:00 1970 +0000
-  summary:     modify a 8
+  \x1b[0;33mchangeset:   10:46106edeeb38\x1b[0m (esc) (?)
+  tag:         tip (?)
+  user:        test (?)
+  date:        Thu Jan 01 00:00:00 1970 +0000 (?)
+  summary:     modify a 10 (?)
+   (?)
+  \x1b[0;33mchangeset:   9:6dd8ea7dd621\x1b[0m (esc) (?)
+  user:        test (?)
+  date:        Thu Jan 01 00:00:00 1970 +0000 (?)
+  summary:     modify a 9 (?)
+   (?)
+  \x1b[0;33mchangeset:   8:cff05a6312fe\x1b[0m (esc) (?)
+  user:        test (?)
+  date:        Thu Jan 01 00:00:00 1970 +0000 (?)
+  summary:     modify a 8 (?)
   
 #else
   $ hg log --limit 3 \



To: Alphare, #hg-reviewers
Cc: mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210805/60fcd161/attachment-0002.html>


More information about the Mercurial-patches mailing list