[Commented On] D11262: repair: improve performance of detection of revisions affected by issue6528

[marmoute (Pierre-Yves David)]

marmoute added a comment.


  Looks overall good, but for the comment I made were we seems to do extra, unnecessary, revision restoration. I'll have a look tomorrow to check if we can safely remove this (and if not, why).

INLINE COMMENTS

> rewrite.py:604
> +    if p1 == nullrev or p2 != nullrev:
> +        metadata_cache[filerev] = rl.rawdata(filerev).startswith(b'\x01\n')
> +        return False

This seems to trigger the slow path for a non linear revision and might slow things down. Why do we needs it ?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11262/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11262

To: Alphare, #hg-reviewers, marmoute
Cc: marmoute, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210806/761efeea/attachment-0002.html>