[Updated] D11284: pyoxidized: adapt test-devel-warnings.t

marmoute (Pierre-Yves David) phabricator at mercurial-scm.org
Wed Aug 18 09:03:00 UTC 2021


marmoute added inline comments.

INLINE COMMENTS

> mharbison72 wrote in test-devel-warnings.t:160
> Is pyoxidizer and chg mutually exclusive?  I'm guessing not because of the changes above, but don't know if you need `no-chg` here.

They are not, but we don't test this combination, especially because `--chg` is not supported on windows and `--pyoxidized` is not supported outside of windows.

So I expect this section to have divergent output if someone get it to run with both chg and pyoxidizer and an extra clause we will be required.

Adding `no-chg` now would simply silently omit that part which seems bad.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11284/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11284

To: marmoute, #hg-reviewers
Cc: mharbison72, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210818/f5d63e25/attachment-0002.html>


More information about the Mercurial-patches mailing list