[Commented On] D11286: pyoxidized: add a dedicated target in the tests

baymax (Baymax, Your Personal Patch-care Companion) phabricator at mercurial-scm.org
Wed Aug 18 10:47:22 UTC 2021


baymax added a comment.
baymax updated this revision to Diff 29910.


  ✅ refresh by Heptapod after a successful CI run (🐙 💚)
  ⚠ This patch is intended for stable ⚠
  <img src="https://phab.mercurial-scm.org/file/data/p334drn6opgk3ac7exvu/PHID-FILE-h4oskowh6xyt7acp2mxz/source.gif" />

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D11286?vs=29895&id=29910

BRANCH
  stable

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11286/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11286

AFFECTED FILES
  Makefile
  tests/run-tests.py

CHANGE DETAILS

diff --git a/tests/run-tests.py b/tests/run-tests.py
--- a/tests/run-tests.py
+++ b/tests/run-tests.py
@@ -3910,7 +3910,7 @@
         vlog('# build a pyoxidized version of Mercurial')
         assert os.path.dirname(self._bindir) == self._installdir
         assert self._hgroot, 'must be called after _installhg()'
-        cmd = b'"%(make)s" pyoxidizer' % {
+        cmd = b'"%(make)s" pyoxidizer-windows-tests' % {
             b'make': b'make',
         }
         cwd = self._hgroot
diff --git a/Makefile b/Makefile
--- a/Makefile
+++ b/Makefile
@@ -270,9 +270,13 @@
 pyoxidizer:
 	$(PYOXIDIZER) build --path ./rust/hgcli --release
 
+# a temporary target to setup all we need for run-tests.py --pyoxidizer
+# (should go away as the run-tests implementation improves
+pyoxidizer-windows-tests: pyoxidizer
+
 .PHONY: help all local build doc cleanbutpackages clean install install-bin \
 	install-doc install-home install-home-bin install-home-doc \
 	dist dist-notests check tests rust-tests check-code format-c \
-	update-pot pyoxidizer \
+	update-pot pyoxidizer pyoxidizer-windows-tests \
 	$(packaging_targets) \
 	osx



To: marmoute, #hg-reviewers
Cc: mharbison72, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210818/a9bcd721/attachment-0002.html>


More information about the Mercurial-patches mailing list