[Commented On] D11307: run-tests: avoid silently switching the hg executable used
mharbison72 (Matt Harbison)
phabricator at mercurial-scm.org
Wed Aug 18 23:29:34 UTC 2021
mharbison72 added a comment.
In D11307#173445 <https://phab.mercurial-scm.org/D11307#173445>, @marmoute wrote:
> I seems a bit weird to be that we try to manually put `self._bindir` and `self._hgcommand` together while if I am not mistaken, they both originate from the splitting of some absolute path somewhere. So keeping that absolute path around would seems safer/cleaner to me. However I might be missing something.
Yeah, that’s where it comes from and I agree it would be better. I’m trying to avoid adding a new variable holding the full path, because I don’t have a way to test that with the rust and chg variants.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D11307/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D11307
To: mharbison72, #hg-reviewers
Cc: marmoute, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210818/06e97fe0/attachment-0002.html>
More information about the Mercurial-patches
mailing list