[Updated] D11309: check-code: drop the camelcase checks

marmoute (Pierre-Yves David) phabricator at mercurial-scm.org
Sun Aug 22 20:37:02 UTC 2021


Closed by commit rHG142a76127e3a: check-code: drop the camelcase checks (authored by marmoute).
This revision was automatically updated to reflect the committed changes.
This revision was not accepted when it landed; it landed in state "Needs Review".

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D11309?vs=29958&id=29982

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11309/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11309

AFFECTED FILES
  contrib/check-code.py

CHANGE DETAILS

diff --git a/contrib/check-code.py b/contrib/check-code.py
--- a/contrib/check-code.py
+++ b/contrib/check-code.py
@@ -340,11 +340,6 @@
         (r'[^\n]\Z', "no trailing newline"),
         (r'(\S[ \t]+|^[ \t]+)\n', "trailing whitespace"),
         (
-            r'^\s+(self\.)?[A-Za-z][a-z0-9]+[A-Z]\w* = ',
-            "don't use camelcase in identifiers",
-            r'#.*camelcase-required',
-        ),
-        (
             r'^\s*(if|while|def|class|except|try)\s[^[\n]*:\s*[^\\n]#\s]+',
             "linebreak after :",
         ),



To: marmoute, #hg-reviewers
Cc: mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210822/905abfdc/attachment-0002.html>


More information about the Mercurial-patches mailing list