[Commented On] D11308: pyoxidizer: add user-site to `sys.path` on Windows

[marmoute (Pierre-Yves David)]

marmoute added a comment.


  In D11308#173760 <https://phab.mercurial-scm.org/D11308#173760>, @mharbison72 wrote:
  
  > In D11308#173544 <https://phab.mercurial-scm.org/D11308#173544>, @marmoute wrote:
  >
  >> This looks good (i.e. similar to what is done in the `./hg` script).
  >> Do you think we could get a test for that in test-extensions ? (using a fake APPDATA for that part of the test) ?
  >
  > I haven't quite got the test working yet (should foo.py in site-packages be loadable, or does it need a directory with `__init__.py`?).  But I see that `site.getuserpackages()` is available on py3, and it would be easier to write a test against that with support for all platforms.  But that should (probably?) go on default, especially since the non pyoxidizer path needs to be updated to stay in sync.  So how about this for stable, and a rework on default that supports py3 everywhere.
  
  You mean getting this specific patch for stable, without a test, and a more complete version for default, with a test ?
  
  That would work for me.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11308/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11308

To: mharbison72, #hg-reviewers
Cc: marmoute, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210823/e7aa2d0b/attachment-0002.html>