[Updated] D11334: revlog: fix type confusion with sidedata_comp_len (issue 6580)

[baymax (Baymax, Your Personal Patch-care Companion)]

baymax added a comment.
baymax retitled this revision from "revlog: fix type confusion with sidedata_comp_len (issue6580)" to "revlog: fix type confusion with sidedata_comp_len (issue 6580)".
baymax updated this revision to Diff 29991.


  :white_check_mark: refresh by Heptapod after a successful CI run (:octopus: :green_heart:)
  ⚠ This patch is intended for stable ⚠
  {image https://media.giphy.com/media/nYI8SmmChYXK0/source.gif}

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D11334?vs=29990&id=29991

BRANCH
  stable

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11334/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11334

AFFECTED FILES
  mercurial/cext/revlog.c

CHANGE DETAILS

diff --git a/mercurial/cext/revlog.c b/mercurial/cext/revlog.c
--- a/mercurial/cext/revlog.c
+++ b/mercurial/cext/revlog.c
@@ -452,9 +452,9 @@
 static PyObject *index_append(indexObject *self, PyObject *obj)
 {
 	uint64_t offset_flags, sidedata_offset;
-	int rev, comp_len, uncomp_len, base_rev, link_rev, parent_1, parent_2;
+	int rev, comp_len, uncomp_len, base_rev, link_rev, parent_1, parent_2, sidedata_comp_len;
 	char data_comp_mode, sidedata_comp_mode;
-	Py_ssize_t c_node_id_len, sidedata_comp_len;
+	Py_ssize_t c_node_id_len;
 	const char *c_node_id;
 	char comp_field;
 	char *data;
@@ -534,9 +534,8 @@
 static PyObject *index_replace_sidedata_info(indexObject *self, PyObject *args)
 {
 	uint64_t offset_flags, sidedata_offset;
-	int rev;
+	int rev, sidedata_comp_len;
 	char comp_mode;
-	Py_ssize_t sidedata_comp_len;
 	char *data;
 #if LONG_MAX == 0x7fffffffL
 	const char *const sidedata_format = PY23("nKiKB", "nKiKB");



To: jcristau, #hg-reviewers, marmoute, Alphare
Cc: Alphare, marmoute, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210824/a19380e0/attachment-0002.html>