[Updated] D11248: store: return just one filename in walk functions

Alphare (Raphaël Gomès) phabricator at mercurial-scm.org
Tue Aug 24 14:27:54 UTC 2021


This revision now requires changes to proceed.
Alphare added a comment.
Alphare requested changes to this revision.


  This looks good aside from the gettext comment, but will (functionally) need to be rebased on top of 5.9 since the fix for issue6528 uses `datafiles` in `mercurial/revlogutils/rewrite.py`.

INLINE COMMENTS

> store.py:584
> +                if undecodable is None:
> +                    raise error.StorageError(b'undecodable revlog name %s' % f1)
> +                else:

This error message should use gettext (i.e. `_()`)

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11248/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11248

To: valentin.gatienbaron, durin42, martinvonz, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210824/b1d50684/attachment-0002.html>


More information about the Mercurial-patches mailing list