[Updated] D11248: store: return just one filename in walk functions

Alphare (Raphaël Gomès) phabricator at mercurial-scm.org
Tue Aug 24 16:09:09 UTC 2021


This revision now requires changes to proceed.
Alphare added a comment.
Alphare requested changes to this revision.


  I will amend both changes in-flight, don't bother.

INLINE COMMENTS

> Alphare wrote in store.py:584
> This error message should use gettext (i.e. `_()`)

This does not pass `black` formatting.

> simplestorerepo.py:680
> +                if undecodable is None:
> +                    raise error.StorageError(b'undecodable revlog name %s' % a1)
> +                else:

Should have been `f1` instead of `a1`.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11248/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11248

To: valentin.gatienbaron, durin42, martinvonz, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210824/2464b2d9/attachment-0002.html>


More information about the Mercurial-patches mailing list