[Changed Subscribers] D11280: fix: reduce number of tool executions

Alphare (Raphaël Gomès) phabricator at mercurial-scm.org
Wed Aug 25 09:33:09 UTC 2021


Alphare added inline comments.

INLINE COMMENTS

> fix.py:396
>  
>      Work items for the same revision are grouped together, so that a worker
>      pool starting with the first N items in parallel is likely to finish the

Maybe update the docstring to reflect the new grouping?

> fix.py:533
>      basepaths = {}
> -    for rev, path in workqueue:
> -        fixctx = repo[rev]
> -        for basectx in basectxs[rev]:
> +    for srcrev, path, dstrevs in workqueue:
> +        fixctx = repo[srcrev]

very minor nit: I usually find it clearer to prefix unused variables with `_`

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11280/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11280

To: hooper, #hg-reviewers
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210825/805e2e13/attachment-0002.html>


More information about the Mercurial-patches mailing list