[Commented On] D11307: run-tests: avoid silently switching the hg executable used

[Alphare (Raphaël Gomès)]

Alphare added a comment.


  In D11307#173446 <https://phab.mercurial-scm.org/D11307#173446>, @mharbison72 wrote:
  
  > I don’t have a way to test that with the rust and chg variants.
  
  You mean under Windows or in general? Because this also feels wrong to me, we should probably be keeping the full path around.

INLINE COMMENTS

> run-tests.py:3682
>          if self._hgcommand != b'hg':
> -            # shutil.which only accept bytes from 3.8
> -            real_exec = which(self._hgcommand)
> +            # _usecorrectpython() may have augmented PATH, so don't used `which`
> +            # on the basename of the explicitly provided executable, since that

/s/used/use/

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11307/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11307

To: mharbison72, #hg-reviewers
Cc: Alphare, marmoute, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210825/5c7f769d/attachment-0002.html>