[Changed Subscribers] D11320: dirstate-item: feed more information to `__init__`

[Alphare (Raphaël Gomès)]

Alphare added inline comments.

INLINE COMMENTS

> parsers.c:107
>  	}
> -	t->state = state;
> -	t->mode = mode;
> -	t->size = size;
> -	t->mtime = mtime;
> -
> +	t->state = 'r';
> +	t->mode = 0;

This differs from the Python implementation (it uses `None`). Why should `'r'` be a good idea here, in particular with the arms that don't set another state later?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11320/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11320

To: marmoute, #hg-reviewers
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210825/b44fdd72/attachment-0002.html>