[Updated] D11320: dirstate-item: feed more information to `__init__`

marmoute (Pierre-Yves David) phabricator at mercurial-scm.org
Thu Aug 26 07:43:40 UTC 2021


marmoute added inline comments.
marmoute requested review of this revision.

INLINE COMMENTS

> Alphare wrote in parsers.c:107
> This differs from the Python implementation (it uses `None`). Why should `'r'` be a good idea here, in particular with the arms that don't set another state later?

We don't have "None" for char, and there are no arms that don't set another state.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11320/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11320

To: marmoute, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210826/bcb7bfbb/attachment-0002.html>


More information about the Mercurial-patches mailing list