[Commented On] D11320: dirstate-item: feed more information to `__init__`

[Alphare (Raphaël Gomès)]

Alphare added inline comments.

INLINE COMMENTS

> marmoute wrote in parsers.c:107
> We don't have "None" for char, and there are no arms that don't set another state.

Sure, but there still is the default state `(!(p1_tracked || p2_tracked || wc_tracked))`, so calling this without any information yields a removed item. I don't think that's a big issue, but probably I would set it to "?" or some other char that doesn't risk silently being eaten anywhere without the dirstate complaining.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11320/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11320

To: marmoute, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210826/41738c10/attachment-0002.html>