[Updated] D11320: dirstate-item: feed more information to `__init__`

marmoute (Pierre-Yves David) phabricator at mercurial-scm.org
Thu Aug 26 08:43:14 UTC 2021


marmoute added inline comments.

INLINE COMMENTS

> Alphare wrote in parsers.c:107
> Sure, but there still is the default state `(!(p1_tracked || p2_tracked || wc_tracked))`, so calling this without any information yields a removed item. I don't think that's a big issue, but probably I would set it to "?" or some other char that doesn't risk silently being eaten anywhere without the dirstate complaining.

In that default state, the file is untracked, (and not entry should actually exist) so `r` is the least unsuitable state at hand.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11320/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11320

To: marmoute, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210826/e19cb305/attachment-0002.html>


More information about the Mercurial-patches mailing list