[Updated] D11839: rhg: Add Repo::write_dirstate

[Alphare (Raphaël Gomès)]

This revision now requires changes to proceed.
Alphare added inline comments.
Alphare requested changes to this revision.

INLINE COMMENTS

> repo.rs:423
> +    ///
> +    /// TODO: have a `WritableRepo` type only accessible while holding the
> +    /// lock?

+1 for a WritableRepo that requires the lock in a future patch

> repo.rs:445
> +            } else {
> +                const ID_LENGTH: usize = 8;
> +                let mut id = String::with_capacity(ID_LENGTH);

This should support `HGTEST_UUIDFILE` (see `mercurial/revlogutils/docket.py`) otherwise some tests will end up failing. Possibly this chould just be a TODO, but I'd rather at least detect the env variable and print a warning to stderr that its support isn't implemented, so that it's more obvious down the line.

> node.rs:178
> +
> +    pub fn pad_to_256_bits(&self) -> [u8; 32] {
> +        let mut bits = [0; 32];

Cool method

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11839/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11839

To: SimonSapin, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20211203/547f6dbf/attachment-0002.html>