[Updated] D11840: rhg: Update the dirstate on disk after status

[Alphare (Raphaël Gomès)]

This revision now requires changes to proceed.
Alphare added inline comments.
Alphare requested changes to this revision.

INLINE COMMENTS

> status.rs:443
> +        let size = fs_contents.len() as u32 & RANGE_MASK_31BIT;
> +        let mtime = TruncatedTimestamp::for_mtime_of(&fs_metadata)
> +            .when_reading_file(&fs_path)?;

I think we should add a comment here explaining why this racy code is not racy (because it's gated behind  the `mtime_boundary` and any change that is caught in this boundary is discarded from this anyway).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11840/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11840

To: SimonSapin, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20211203/c7642fc8/attachment-0002.html>