[Updated] D11835: rhg: Initial repository locking

SimonSapin phabricator at mercurial-scm.org
Mon Dec 6 09:21:35 UTC 2021


SimonSapin added inline comments.

INLINE COMMENTS

> Alphare wrote in lock.rs:125
> There is not I'm afraid.

Yeah it just feels weird to go through `std::io::Error`. I wish the libc crate exposed something to access errno, even though it might need to be more than a simple FFI binding. I’ll remove this comment.

> Alphare wrote in lock.rs:169
> You can catch `ENOTDIR` with `error.raw_os_error() == Some(20)`

Good point, I’ll change the whole `match` to look at errno values

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11835/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11835

To: SimonSapin, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20211206/73e69ad1/attachment-0002.html>


More information about the Mercurial-patches mailing list