[Updated] D11839: rhg: Add Repo::write_dirstate

[SimonSapin]

SimonSapin added inline comments.

INLINE COMMENTS

> Alphare wrote in repo.rs:445
> This should support `HGTEST_UUIDFILE` (see `mercurial/revlogutils/docket.py`) otherwise some tests will end up failing. Possibly this chould just be a TODO, but I'd rather at least detect the env variable and print a warning to stderr that its support isn't implemented, so that it's more obvious down the line.

> I'd rather at least detect the env variable and print a warning

The env variable is always set by `run-tests.py`, so a warning would affect the output of every single test where `hg status` writes dirstate updates. So if a warning exists the only practical thing for tests would be to silence it, but that’s the only place where it would happen.

I’ll add a TODO comment and no warning.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11839/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11839

To: SimonSapin, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20211207/fccf4b1c/attachment-0002.html>