[Updated] D11880: rhg: demonstrate that rhg breaks on non-generaldelta revlogs
aalekseyev (Arseniy Alekseyev)
phabricator at mercurial-scm.org
Wed Dec 8 12:06:05 UTC 2021
aalekseyev added inline comments.
INLINE COMMENTS
> Alphare wrote in test-rhg-no-generaldelta.t:17
> This looks very complicated to not do much? I might not understand what it's trying to achieve
The idea was to:
- produce a large enough output that delta is always used (seq 50)
- have a non-linear history because I thought the bug only happens with non-linear history (I no longer believe that)
- make the last diff a removal at line 1, so that it cleanly applies at any revision. This means that the error is only caught by hash verification, rather than by a "lucky" index-out-of-bounds
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D11880/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D11880
To: aalekseyev, #hg-reviewers
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20211208/e882c65a/attachment-0002.html>
More information about the Mercurial-patches
mailing list