[Commented On] D11880: rhg: demonstrate that rhg breaks on non-generaldelta revlogs

[Alphare (Raphaël Gomès)]

Alphare added inline comments.

INLINE COMMENTS

> aalekseyev wrote in test-rhg-no-generaldelta.t:17
> The idea was to:
> 
> - produce a large enough output that delta is always used (seq 50)
> - have a non-linear history because I thought the bug only happens with non-linear history (I no longer believe that)
> - make the last diff a removal at line 1, so that it cleanly applies at any revision. This means that the error is only caught by hash verification, rather than by a "lucky" index-out-of-bounds

I was very specifically talking about the `(seq.py 50; echo x) | (read; cat) > f` part. Using `tail -n +2 f` gives you the same result while being less confusing (I think). Adding a comment saying what you're doing might be worthwhile too.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11880/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11880

To: aalekseyev, #hg-reviewers
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20211208/79f88c30/attachment-0002.html>