[Commented On] D11880: rhg: demonstrate that rhg breaks on non-generaldelta revlogs

aalekseyev (Arseniy Alekseyev) phabricator at mercurial-scm.org
Wed Dec 8 12:36:17 UTC 2021


aalekseyev added inline comments.

INLINE COMMENTS

> Alphare wrote in test-rhg-no-generaldelta.t:17
> I was very specifically talking about the `(seq.py 50; echo x) | (read; cat) > f` part. Using `tail -n +2 f` gives you the same result while being less confusing (I think). Adding a comment saying what you're doing might be worthwhile too.

Oh, I started with `tail -n +2`, but I switched to `read; cat` because I thought it's more portable and cleaner.
Let me clean it up further, actually, by introducing an explicit header line so we can drop it easier. (pushed a change)

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11880/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11880

To: aalekseyev, #hg-reviewers
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20211208/8e3cf914/attachment-0002.html>


More information about the Mercurial-patches mailing list