[Updated] D11869: upgrade: explicitly warn when a `--no-xxx` flag is overwritten

[Alphare (Raphaël Gomès)]

This revision now requires changes to proceed.
Alphare added a comment.
Alphare requested changes to this revision.


  There is also a typo in the commit message: s/server/series/

INLINE COMMENTS

> upgrade.py:107
> +        if action.touches_filelogs and FL not in touched_revlogs:
> +            if FL in specified_revlogs:
> +                if not specified_revlogs[FL]:

I think it would be simpler (and technically faster even though it most likely doesn't matter here) to say `if not specified_revlogs.get(FL)` (same for the other two similar places)

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11869/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11869

To: marmoute, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20211210/f7998bb6/attachment-0002.html>