[Updated] D11870: upgrade: issue a message when a revlog type has to be upgraded

[Alphare (Raphaël Gomès)]

This revision now requires changes to proceed.
Alphare added inline comments.
Alphare requested changes to this revision.

INLINE COMMENTS

> upgrade.py:114
> +            else:
> +                msg = select_msg % (b'all-filelogs', action.name)
> +                ui.status(msg)

Should be `all filelogs` since this is user-facing

> upgrade.py:127
> +            else:
> +                msg = select_msg % (b'manifestlog', action.name)
> +                ui.status(msg)

The UI uses "manifest", I think "manifestlog" will be confusing for some users. Also, shouldn't it be "all manifests"?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11870/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11870

To: marmoute, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20211210/f79a56ef/attachment-0002.html>