[Updated] D11869: upgrade: explicitly warn when a `--no-xxx` flag is overwritten

[marmoute (Pierre-Yves David)]

marmoute added inline comments.

INLINE COMMENTS

> Alphare wrote in upgrade.py:107
> I think it would be simpler (and technically faster even though it most likely doesn't matter here) to say `if not specified_revlogs.get(FL)` (same for the other two similar places)

There is a semantic difference between the lack of value (None, no flag passed) and an explicite "False" (--no-xxx) flag passed.

So this does not seems an option here.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11869/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11869

To: marmoute, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20211210/529b1a5a/attachment-0002.html>