[Commented On] D11869: upgrade: explicitly warn when a `--no-xxx` flag is overwritten

Alphare (Raphaël Gomès) phabricator at mercurial-scm.org
Fri Dec 10 10:16:12 UTC 2021


Alphare added inline comments.

INLINE COMMENTS

> marmoute wrote in upgrade.py:107
> There is a semantic difference between the lack of value (None, no flag passed) and an explicite "False" (--no-xxx) flag passed.
> 
> So this does not seems an option here.

Would `if specified_revlogs.get(FL) == False` work?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11869/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11869

To: marmoute, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20211210/61f6a67e/attachment-0002.html>


More information about the Mercurial-patches mailing list