[Updated] D11870: upgrade: issue a message when a revlog type has to be upgraded

marmoute (Pierre-Yves David) phabricator at mercurial-scm.org
Fri Dec 10 10:16:56 UTC 2021


marmoute added inline comments.

INLINE COMMENTS

> Alphare wrote in upgrade.py:114
> Should be `all filelogs` since this is user-facing

I prefer to use a single word approach for this (to the user) so that it is clearer that this is monolithic thing.

> Alphare wrote in upgrade.py:127
> The UI uses "manifest", I think "manifestlog" will be confusing for some users. Also, shouldn't it be "all manifests"?

We are processing revlogs here, I find manifestlog clearer. Keep in mind that this is a debug command and the user here is likely some kind of admin.

We can make it all-manifestlogs as tree manifest exists.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11870/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11870

To: marmoute, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20211210/1aff168e/attachment-0002.html>


More information about the Mercurial-patches mailing list